GitBulletin

Repository: farcasterxyz/hub-monorepo

Code Overhaul: Hub-Web Package Revolutionizes Signature Process with Crucial Update!

2024-02-24 02:12:12 UTC

Go and Rust examples transformed to enhance security by signing hash bytes, aligning with the latest specifications.

Commit Details:

fix: Update go and rust examples in hub-web package to sign hash bytes instead of message data (#1742) ## Motivation Fixes: #1720 ## Change Summary Change which content gets signed for generating signature to match spec ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [ ] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [ ] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [x] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) ## Additional Context Not sure if need to do changeset, just updating the examples. Messages proto in the rust examples was generated from build.rs I guess, let me know if that's not necessary to include <!-- start pr-codex --> --- ## PR-Codex overview This PR updates signature handling in Golang and Rust examples, renames `VerificationAddEthAddressBody` to `VerificationAddAddressBody`, and adds `FrameActionBody`. ### Detailed summary - Updated signature handling in Golang and Rust examples - Renamed `VerificationAddEthAddressBody` to `VerificationAddAddressBody` - Added `FrameActionBody` in Rust example > The following files were skipped due to too many changes: `packages/hub-web/examples/rust-submitmessage/src/message.rs` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->

Search Similar