GitBulletin

Repository: farcasterxyz/hub-monorepo

Code Crusader Conquers Type Turmoil: Test Stability Restored!

2024-07-12 04:09:49 UTC

Spark of innovation in debugging as developers tackle unhandled errors, ensuring robust comparison in critical testing environment.

Commit Details:

chore: fix unhandled type error in tests (#2161) ## Why is this change needed? Fixing this type error that started showing up in my local environment. Unclear why it started triggering now, but the fix is to just cast it and do the comparison. There's a small edge case here that if the types were not strict Uint8Arrays the tests might still pass. But that doesn't seem to be the spirit of what we're testing here. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [ ] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. <!-- start pr-codex --> --- ## PR-Codex overview This PR updates a test file in `messageDataBytes.test.ts` to fix a comparison issue in a test case related to decoding message data bytes. ### Detailed summary - Fixed comparison issue in a test case by ensuring both sides are of type Uint8Array. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->

Search Similar