GitBulletin

Repository: farcasterxyz/hub-monorepo

Tech Triumph: Axios Error Handling Gets a Major Upgrade!

2024-04-15 15:48:15 UTC

Developer Team Enhances Reporting Accuracy to Datadog, Ensuring Smooth Data Flow and Robust Analytics.

Commit Details:

fix: Handle axios errors while reporting errors (#1909) ## Motivation Handle axios errors while reporting errors to datadog ## Change Summary Describe the changes being made in 1-2 concise sentences. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [X] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [X] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [ ] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [X] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on fixing axios error handling while reporting to Datadog in the `diagnosticReportWorker.ts` file. ### Detailed summary - Updated `response` variable to use `Result` type for axios response - Modified error handling logic based on `Result` type - Changed return type of `postDataDogEvent` and `postErrorEvent` functions to `Result` type > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->

Search Similar