GitBulletin

Repository: farcasterxyz/hub-monorepo

Code Correction Chronicles: Target Fid Check Gets Major Makeover!

2024-07-24 21:35:37 UTC

New Update Resolves Message Confusion, Ensures Valid Link Communications Flow Smoothly Across Time!

Commit Details:

fix: Fix incorrect target fid check for link messages older than the compact state (#2207) ## Why is this change needed? We were checking for the message creator's fid instead of the target fid and therefore rejecting valid messages older than the compact state ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. <!-- start pr-codex --> --- ## PR-Codex overview This PR fixes an issue with target fid check for link messages older than the compact state in the `store.rs` file and adds tests in `linkStoreCompactState.test.ts`. ### Detailed summary - Fixed incorrect target fid check for link messages in `store.rs` - Added tests for merging link add messages in `linkStoreCompactState.test.ts` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->

Search Similar