GitBulletin

Repository: farcasterxyz/hub-monorepo

Tech Triumph: Major Fix to Fname Events Ends Replay Roulette!

2024-07-24 21:48:28 UTC

Developers Unveil Solution to Chronic Old Event Re-Addition, Streamlining User Experience in Revolutionary Hub Update!

Commit Details:

fix: do not let deleted fname events allow old fname events to be re-added (#2203) ## Why is this change needed? The fname events are not coming through correctly for a few names, and by consequence we're seeing a few old fname events being endlessly replayed. The deletion of the fname record (when fid = 0 in proof) completely removes the record rather than its association with a fid, and by consequence replaying the older event re-adds the fname. This resolves the hub side of the behavior by correctly holding on to the new fname event, but deleting the association with a fid. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [x] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. <!-- start pr-codex --> --- ## PR-Codex overview The focus of this PR is to enhance the `hubble` app by fixing issues related to username proof handling and syncing historical events. ### Detailed summary - Fixed issue where deleted fname events allowed re-adding old fname events - Improved syncing historical events in `syncEngine.ts` - Updated `mergeUserNameProof` functionality in tests - Added `rsGetUserNameProof` import in `nameRegistryEvent.ts` - Enhanced `UserDataStore` functionality in `user_data_store.rs` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->

Search Similar